Skip to content

Refactor UndoControl Panel #5057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

Tishasoumya-02
Copy link
Contributor

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 4bc423d
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64d64ad173504100078dc404

@cypress
Copy link

cypress bot commented Aug 4, 2023

Passing run #6814 ↗︎

0 553 20 0 Flakiness 0

Details:

storybook update
Project: Volto Commit: 4bc423d4ca
Status: Passed Duration: 16:12 💡
Started: Aug 11, 2023 2:54 PM Ended: Aug 11, 2023 3:10 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@stevepiercy
Copy link
Collaborator

@Tishasoumya-02 the number of changed files is over 3000. Something doesn't seem right in this PR. It may be easier to start with a new PR from main with only the changes you want.

@davisagli
Copy link
Member

@stevepiercy I don't know what you're seeing. I only see 4 changed files.

@stevepiercy
Copy link
Collaborator

@davisagli weird. I guess I hit GitHub while it was churning through the diff. It displayed a that warning of a 3000 file limit, and the left nav expanded to show thousands of files. Now it just shows 4.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweak to news. Looks good. Still needs a technical review. Thank you!

@stevepiercy
Copy link
Collaborator

@Tishasoumya-02 needs some lint and prettier. Also check that the change log is in the right place. https://github.com/plone/volto/actions/runs/14668097934/job/41167838378?pr=5057

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News is OK now. Still needs to pass ESLint and move news to correct location per https://6.docs.plone.org/contributing/index.html#create-a-news-item-file

@Tishasoumya-02
Copy link
Contributor Author

@stevepiercy yes , still working on this will make the changes.

@Tishasoumya-02
Copy link
Contributor Author

@stevepiercy, PR good to be reviewed again!

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but still needs a technical review.

@stevepiercy stevepiercy requested a review from a team April 27, 2025 10:37
@github-project-automation github-project-automation bot moved this to Needs discussion in Volto Team Meeting Apr 27, 2025
@stevepiercy stevepiercy moved this from Needs discussion to Plan approved in Volto Team Meeting Apr 27, 2025
@stevepiercy stevepiercy requested a review from pnicolli April 27, 2025 10:38
@stevepiercy
Copy link
Collaborator

@pnicolli I added this item to Volto Team Meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Plan approved
Development

Successfully merging this pull request may close these issues.

3 participants