-
-
Notifications
You must be signed in to change notification settings - Fork 785
Refactor UndoControl Panel #5057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for volto canceled.
|
@Tishasoumya-02 the number of changed files is over 3000. Something doesn't seem right in this PR. It may be easier to start with a new PR from |
@stevepiercy I don't know what you're seeing. I only see 4 changed files. |
@davisagli weird. I guess I hit GitHub while it was churning through the diff. It displayed a that warning of a 3000 file limit, and the left nav expanded to show thousands of files. Now it just shows 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweak to news. Looks good. Still needs a technical review. Thank you!
@Tishasoumya-02 needs some lint and prettier. Also check that the change log is in the right place. https://github.com/plone/volto/actions/runs/14668097934/job/41167838378?pr=5057 |
Co-authored-by: Steve Piercy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
News is OK now. Still needs to pass ESLint and move news to correct location per https://6.docs.plone.org/contributing/index.html#create-a-news-item-file
@stevepiercy yes , still working on this will make the changes. |
@stevepiercy, PR good to be reviewed again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but still needs a technical review.
@pnicolli I added this item to Volto Team Meeting. |
#4460