Laggy UI response while editing - Test: try Jotai instead of Redux. #6991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneridagh
requested review from
davisagli,
tiberiuichim,
ichim-david and
robgietema
sneridagh
changed the title
* main: Fixed `unRegisterSlotComponent` method (#7016) Fix __mocks__ folder which breaks addon testing (#7001) Pin plone-sphinx-theme to prepare for PLIP 4097 (#7015) Added current evaluated `querystring` as a parameter in expander `querystring` key when it is a function (#7012) Linkcheck 2025 04 22 part 2 (#7011) Linkcheck 2025 04 22 (#7010) Allow `object_list` widget to receive a `schemaName` prop, mapped to an utility (#7007) Fix boolean in blocks edit config `BlockEditProps` `selected` type (#6995) Fix/addon break in volto (#6992)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been some time that I wanted to take a look at it, because in dev, the performance problems are quite noticeable, also, we have reports that in old machines it's unbearable... Luckily, it seems that in production builds, it's not that bad...
Anyways, I think we should be doing something in a non-performant way in the Redux side. Also, the fact that on every key press, all the store gets replaced with that big object, does not help...
So I did a quick try, and I replaced Redux with a Jotai atom and the results are quite good:
Before ( I was typing non-stop all the time...):
sluggish.mov
After:
goodperformance.mov
So, I'd try to find a way to improve the situation using Redux, because anything else would be a breaking change. Maybe reconsider the solution for 19.
@robgietema could you please take a look?