Fix missing index in CSTR.equations #232
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to instantiate
neuromancer.psl.nonautonomous.CSTR
-- not even with default arguments; after some investigation, I found out that this is due to a missing index in theCSTR.equations
method, which results in its output beingand this mix of a scalar and rank 0 array causes issues later on
.cast
calls in thecast_backend
decorator.I think this PR would also solve #229