Skip to content

Use ES6 Modules #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Use ES6 Modules #5

wants to merge 6 commits into from

Conversation

ear1grey
Copy link
Contributor

No longer reliant on global namespace for sharing functions.

@ear1grey ear1grey requested a review from jacekkopecky March 16, 2019 13:05
jacekkopecky
jacekkopecky approved these changes Mar 16, 2019
View reviewed changes
Copy link
Contributor

@jacekkopecky jacekkopecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; will the linter stop complaining about much of our html?

should we merge it now or in the lecture? It could be useful to show the old version and the new one.

@jacekkopecky
Copy link
Contributor

Thank you! For future commits, linter fixes are commonly abbreviated as 👕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacekkopecky jacekkopecky jacekkopecky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ear1grey @jacekkopecky