Skip to content

Fix: Start systemtest counter from 1 instead of 0 #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

BytePaul
Copy link

@BytePaul BytePaul commented May 9, 2025

Summary

Previously, the counter in log messages started from 0, which could be confusing to users expecting 1-based indexing.

Before:

INFO: Started running Flow over heated plate, 0/2
INFO: Started running Perpendicular flap, 1/2

After:

INFO: Started running Flow over heated plate, 1/2
INFO: Started running Perpendicular flap, 2/2

Changes Made

  • Modified tools/tests/systemtests.py to change the counter from number to number + 1 in the log line.

Fix: start counter from 1 in log output
@MakisH
Copy link
Member

MakisH commented May 9, 2025

This closes #644

@MakisH
Copy link
Member

MakisH commented May 9, 2025

Thank you for the fix! Could you please also port this to the following files, which suffer from the same issue?

@BytePaul
Copy link
Author

Hi!
I have made the changes requested by you.

@MakisH
Copy link
Member

MakisH commented May 12, 2025

Hi @BytePaul,

please push the updates to the same branch (BytePaul:paulg) and close the other PRs (#651, #652).

In next PRs, it would be more convenient both for you and for everyone reviewing PRs to name branches based on what they contribute (for example, system-tests-counter would have been a good name here). This is fine for this one, but later on you might get confused by the multiple branches in your fork.

@BytePaul BytePaul closed this May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants