-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Minimal shape docs #7749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Minimal shape docs #7749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2cd6d5
to
3554eb3
Compare
davepagurek
reviewed
Apr 17, 2025
davepagurek
reviewed
Apr 17, 2025
davepagurek
reviewed
Apr 17, 2025
davepagurek
reviewed
Apr 17, 2025
Co-authored-by: Dave Pagurek <[email protected]>
Co-authored-by: Dave Pagurek <[email protected]>
ksen0
commented
Apr 17, 2025
Co-authored-by: Dave Pagurek <[email protected]>
Co-authored-by: Dave Pagurek <[email protected]>
davepagurek
reviewed
Apr 17, 2025
davepagurek
reviewed
Apr 17, 2025
davepagurek
reviewed
Apr 17, 2025
davepagurek
reviewed
Apr 17, 2025
davepagurek
reviewed
Apr 17, 2025
davepagurek
reviewed
Apr 17, 2025
davepagurek
reviewed
Apr 17, 2025
davepagurek
reviewed
Apr 17, 2025
Co-authored-by: Dave Pagurek <[email protected]>
Co-authored-by: Dave Pagurek <[email protected]>
davepagurek
reviewed
Apr 17, 2025
24 tasks
davepagurek
reviewed
Apr 17, 2025
Co-authored-by: Dave Pagurek <[email protected]>
66fc232
to
9afdd0e
Compare
ksen0
commented
Apr 17, 2025
@@ -487,6 +487,9 @@ function loading(p5, fn){ | |||
} | |||
}; | |||
|
|||
/** | |||
* @private |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davepagurek Actually should this be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using abridged list from: #7734 but focusing only on minimal necessary docs to get started:
bezierOrder()
bezierVertex()
docsquadraticVertex()
docssplineVertex()
curveVertex()
(it's already supported by the 1.x compatibility add-on for shapes)vertexProperty()
docs (sense check)splineProperty()
splineProperties()
beginShape()
docs - reviewed, already OKbeginContour()
docsendShape/Contour(CLOSE)
behavior for splinesendContour(CLOSE)
docscurve()
docs to reflect name change tospline()
curveTightness()
docscurvePoint()
docs to reflect name change tosplinePoint()
curveTangent()
docs to reflect name change tosplineTangent()
curveDetail()
docs, possibly incorporating adapted examples frombezierDetail()
docsbezierDetail()
docsbeginGeometry()
/endGeometry()
docsvertex()
docs - https://beta.p5js.org/reference/p5/texture/