TC-IDM-13.1: Add check for default fixed labels #38805
Open
+83
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These appear a LOT in production data. Add a warning. These don't actually make any sense to have as fixed labels - there is no way to tell a-priori that a device will always reside in bedroom 2, on the second floor on the north side facing upwards.
|
PR #38805: Size comparison from f89539f to 1a21772 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38805: Size comparison from 79faaa3 to edd389d Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These appear a LOT in production data. Add a warning. These don't actually make any sense to have as fixed labels - there is no way to tell a-priori that a device will always reside in bedroom 2, on the second floor on the north side facing upwards.
test plan PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/5144
Testing
Added unit tests (see TestDefaultWarnings.py file in this PR), test is run in CI