feat: incident.io Notifier #4372
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorymalcolm
changed the title
rorymalcolm
force-pushed
the
rorymalcolm/incidentio-notifier
branch
2 times, most recently
from
98ed08f to
416cac1
Compare
rorymalcolm
force-pushed
the
rorymalcolm/incidentio-notifier
branch
2 times, most recently
from
2de7c7f to
118a310
Compare
- Adds the technical implementation, and tests, for the incident.io notifier
- Configured through the following config:
```yaml
receivers:
- name: 'incidentio-notifications'
incidentio_configs:
- url: '$alert_source_url'
alert_source_token: '$alert_source_token'
```
Signed-off-by: Rory Malcolm <[email protected]>
rorymalcolm
force-pushed
the
rorymalcolm/incidentio-notifier
branch
from
118a310 to
4bc00a7
Compare
axdotl
reviewed
Apr 30, 2025
| @@ -521,6 +528,49 @@ func (c *SlackConfig) UnmarshalYAML(unmarshal func(interface{}) error) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // IncidentioConfig configures notifications via incident.io. | |||
| type IncidentioConfig struct { | |||
There was a problem hiding this comment.
What do you think about adding a field Metadata to this struct? Something similar to the Details field in the OpsgenieConfig struct.
This would enable users to define additional data (see incident.io API definition for reference).
rorymalcolm
force-pushed
the
rorymalcolm/incidentio-notifier
branch
3 times, most recently
from
17d6a6f to
255befe
Compare
|
You have some lint failures in |
rorymalcolm
force-pushed
the
rorymalcolm/incidentio-notifier
branch
2 times, most recently
from
8f16fcd to
bbc39ce
Compare
|
You still have some failing tests I'm afraid https://github.com/prometheus/alertmanager/actions/runs/14933150149/job/41982648209?pr=4372 |
- Made a change to demarcate `AlertSourceToken` as required - Now error if an authorization header is set, and a alert_source_token is set - Ensure the alert source endpoint is no longer secret - Add documentation for the incidentio_config Signed-off-by: Rory Malcolm <[email protected]>
rorymalcolm
force-pushed
the
rorymalcolm/incidentio-notifier
branch
from
bbc39ce to
07604e3
Compare
Ah - apols; fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4367
Adds the technical implementation, and tests, for the incident.io notifier
Configured through the following config: