Set 'us-central1' by default on GoogleProvider
#2031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
dhimmel
approved these changes
Jun 20, 2025
samuelcolvin
approved these changes
Jun 26, 2025
| @@ -104,7 +104,7 @@ def __init__( | |||
| self._client = genai.Client( | |||
| vertexai=vertexai, | |||
| project=project or os.environ.get('GOOGLE_CLOUD_PROJECT'), | |||
| location=location or os.environ.get('GOOGLE_CLOUD_LOCATION'), | |||
| location=location or os.environ.get('GOOGLE_CLOUD_LOCATION') or 'us-central1', | |||
There was a problem hiding this comment.
Suggested change
| location=location or os.environ.get('GOOGLE_CLOUD_LOCATION') or 'us-central1', | |
| location=location or os.environ.get('GOOGLE_CLOUD_LOCATION') or 'global', |
I think that's better.
There was a problem hiding this comment.
I don't think there's a perfect value according to the docs. Select quotes:
- "Selecting a global endpoint for your requests can improve overall availability while reducing resource exhausted (429) errors"
- Usage of the global endpoint is supported for the following Google models... [gemini 2.0 and 2.5]
- For some models, Google also offers a global endpoint (Preview)
Currently us-central1 supports the most models by far of any region including global, but not all of them. us-central1 has all google models but is missing some Anthropic partner models, which use us-east5 instead. global has fewer models but higher availability.
Google is not making like easy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.