-
Notifications
You must be signed in to change notification settings - Fork 964
feat: add ToolReturn for customizable tool return #2060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Change SummaryAdded support for customizable multi-modal content presentation using the new
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
4f6d660
to
3b14091
Compare
@DouweM I did some refactoring and now I use the |
@@ -393,6 +410,9 @@ class ToolReturnPart: | |||
tool_call_id: str | |||
"""The tool call identifier, this is used by some models including OpenAI.""" | |||
|
|||
extra_data: Any = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this could be named artifacts
as it is idiomatic with langchain and some other libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not so sure the artifacts are clear enough as I haven't gone through langchain...
Leave it up to @DouweM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thisisarko What other languages call it artifacts
? I personally like metadata
better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I saw some references elsewhere but langchain is the major one that I am sure of. I am good with metadata
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -393,6 +410,9 @@ class ToolReturnPart: | |||
tool_call_id: str | |||
"""The tool call identifier, this is used by some models including OpenAI.""" | |||
|
|||
extra_data: Any = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thisisarko What other languages call it artifacts
? I personally like metadata
better.
Co-authored-by: Douwe Maan <[email protected]>
Co-authored-by: Douwe Maan <[email protected]>
closes #2034
This PR allows us to implement more complex tool return like computer use
Example response:
previous: #1517