Fix bug with google model safety handling #2066
Open
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported in https://pydanticlogfire.slack.com/archives/C083V7PMHHA/p1750795268032809. It looks to me like this was just an oversight in the implementation, apparently coming from the duplication in handling between streaming and non-streaming code. (Was implemented more thoroughly for non-streaming than streaming; this brings it up to parity.)
I'm not sure of a good way to reproduce the issue so I haven't added a test, but I suspect it's probably not that hard if you know what triggers it. But I'm also not sure how hard it is to add streaming tests etc.