Skip to content

Harpy cleanup #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Harpy cleanup #473

wants to merge 9 commits into from

Conversation

jgray-19
Copy link
Contributor

Some general cleanup from trying to understand the code - functionality should not be changed.

Other changes:

  • Removed the copying of options and opt.files = file (In HIO)
  • Convert paths to use Path rather than os functions
  • Added a warning when some attributes are given alongside model directory, so user knows when their inputs are used.

@jgray-19 jgray-19 added Type: Maintenance Improvements in the code, that are not necessarily visible in functionality. Estimate: Easy Good first issue for newcomers. Straightforward fixes. Priority: Low Work on this if you have some spare time. Status: In Progress Currently being worked on. labels Nov 22, 2024
Copy link

codeclimate bot commented Jan 14, 2025

Code Climate has analyzed commit d78ab78 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 94.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.1% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: Easy Good first issue for newcomers. Straightforward fixes. Priority: Low Work on this if you have some spare time. Status: In Progress Currently being worked on. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant