-
Notifications
You must be signed in to change notification settings - Fork 32
Value-By-Alpha implementation from mapclassify
from splot
#274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
=======================================
- Coverage 90.1% 83.3% -6.8%
=======================================
Files 10 11 +1
Lines 1185 1332 +147
=======================================
+ Hits 1068 1110 +42
- Misses 117 222 +105
🚀 New features to boost your workflow:
|
@sjsrey – do you think I should go ahead and add tests here or wait for other's comments? Probably can simply decorate the functions here the need Maybe also go ahead and do that with the |
I'd wait to hear from others before adding tests. |
splot
inmapclassify
– integrate VBA classification fromsplot
intomapclassify
#272.matplotlib
dependencysplot.mapping.mapclassify_bin
into mapclassify splot#118vba_choropleth
splot#173splot
intomapclassify
#272