Skip to content

Value-By-Alpha implementation from mapclassify from splot #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Jun 22, 2025


@jGaboardi jGaboardi self-assigned this Jun 22, 2025
Copy link

codecov bot commented Jun 22, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 105 lines in your changes missing coverage. Please review.

Project coverage is 83.3%. Comparing base (0a209cf) to head (9191be6).

Files with missing lines Patch % Lines
mapclassify/value_by_alpha.py 28.1% 105 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0a209cf) and HEAD (9191be6). Click for more details.

HEAD has 14 uploads less than BASE
Flag BASE (0a209cf) HEAD (9191be6)
28 14
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #274     +/-   ##
=======================================
- Coverage   90.1%   83.3%   -6.8%     
=======================================
  Files         10      11      +1     
  Lines       1185    1332    +147     
=======================================
+ Hits        1068    1110     +42     
- Misses       117     222    +105     
Files with missing lines Coverage Δ
mapclassify/__init__.py 100.0% <100.0%> (ø)
mapclassify/_classify_API.py 96.6% <ø> (ø)
mapclassify/value_by_alpha.py 28.1% <28.1%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi
Copy link
Member Author

@sjsrey – do you think I should go ahead and add tests here or wait for other's comments?

Probably can simply decorate the functions here the need matplotlib with libpysal's @requires.

Maybe also go ahead and do that with the legendgram stuff, but will need need to import the matplotlib stuff in each function unless I am missing something.

@sjsrey
Copy link
Member

sjsrey commented Jun 24, 2025

@sjsrey – do you think I should go ahead and add tests here or wait for other's comments?

Probably can simply decorate the functions here the need matplotlib with libpysal's @requires.

Maybe also go ahead and do that with the legendgram stuff, but will need need to import the matplotlib stuff in each function unless I am missing something.

I'd wait to hear from others before adding tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants