Skip to content

gh-137376: ensure that SyntaxError are properly detected in REPL #137378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Aug 4, 2025

This is very fast hack because I need to go and won't be able to do any work. I plan to handle better the arguments to symtable.symtable but the idea is to re-use the same flags that were passed to the compiler since otherwise some tests fail (the barry test fails because the future is added separately, and symtable on <> would fail as it doesn't know about the future).

@picnixz picnixz marked this pull request as ready for review August 5, 2025 07:52
@picnixz
Copy link
Member Author

picnixz commented Aug 5, 2025

Ok this approach is still incomplete. I could write something like x = 1, hit ENTER, and then write global x; x = 2.

EDIT: This appears to be the same since at least Python 3.6.

@picnixz picnixz marked this pull request as draft August 5, 2025 08:11
@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 5, 2025
@picnixz picnixz marked this pull request as ready for review August 5, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant