-
Notifications
You must be signed in to change notification settings - Fork 55
Update : Command for python 3 added #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@akshayaurora would be great if you could take a look. |
@Shivang-Bhandari please specify the python version you are using. |
@realslimshanky Python 3.6.0 |
@Shivang-Bhandari If you have tested it on 3.6.0 specifically do mention in the README about it. Because other versions might fail to run the script. |
@realslimshanky sure |
README.md
Outdated
@@ -12,6 +12,11 @@ To monitor your source directory for changes, and recompile files if they change | |||
python build.py & python -m SimpleHTTPServer && fg | |||
``` | |||
|
|||
For Python 3.6.0 : | |||
``` | |||
python build.py & python -m http.server && fg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work for all versions > 3.3
Its better to mention that, 3.6 was released recently, but this should work with relatively newer python 3 versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SanketDG in the above comments @realslimshanky said it was not working for him for version 3.5.2, it would be great if you could update me and I can make the necessary changes. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late response, but the above code should work for any versions > 3.3 since there have been no breaking changes after that.
So you can go ahead and change that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SanketDG Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if you could merge it
:)
@SanketDG would you like to have another look after the update? |
@realslimshanky LGTM |
Updated the command to run the project locally using Python 3