-
Notifications
You must be signed in to change notification settings - Fork 22
Added About Us Page - Pycon2025 ✨ #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inpycon2025 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some review please have a look and address them please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replied and added more reviews
@dhanushk-offl can you please squash your commits. |
Refactor team section layout and improve responsiveness ✨ Refactor team members data structure and remove redundant entries ✨ Updated Team Members details ✨ Replace Get Tickets button with existing UI for consistency ✨ Remove unused font import from main.css and fix newline issues in JSON and NJK files ✨ Back to old button ✨
Done @ashish10677! Make a review and merge it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am already fixed it.. can you Try it once again |
Don't see it. No commits since the comments. Code remains same. Preview remains same. |
… about page styles for better responsiveness ✨
Hey @anistark, can you check now? |
I still see this: Check yourself for all sizes: https://deploy-preview-119--inpycon2025.netlify.app/about/ |
But, it works well for all devices and screens! I tested with all screens and commit these changes! Which device are you using, and can you check/ reset your browser zoom size as fit? |
Chrome on Mac using the preview link. Check for 720 x 934 px Just follow other pages design style. Don't try to redo what's already solved in other pages. This is why I wanted to get the static page layout done first. |
Also, not all current active volunteers are mentioned here anyway. @ashish10677 perhaps can help with it. Please remove whoever isn't active and add the active ones. |
Now you can check @anistark! Made some padding adjustments, Hope it'll works as we expected! 🙌 |
Yeah @anistark , we can merge for now. We can add more volunteers as we find them in upcoming pushes. What's your thoughts @ashish10677? |
src/about.njk
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a about directory. Put this file inside it for structural consistency.
Should at least have all the current active volunteers listed. Or keep only the leads. |
Better, we can merge upto this after the current changes and we create a separate issue to add volunteers details, to be added by @ashish10677 and hope it's doesn't takes much time to do.. |
…enu links for clarity ✨
Nope. If it's going live, should go live with all current active or only leads listed. |
…y and about routes ✅
The submenu is already there. Last year it was team page separately. We're combining team, about everything in single about page this time. |
Done! Please check the recent commit! If everything fine! I'll squash the commits! |
So @anistark , can we wait until active volunteers details to be added by me or @ashish10677 / make the page live with WG Leads details alone? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Let's wait for @ashish10677 to get back with current active volunteers to get things going.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can name page as index.njk
That way, the path url would be http://in.pycon.org/2025/about
. Now, the url is http://in.pycon.org/2025/about/about
We won't have to force route mapping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for images hosted, would suggest to use magic convert
to have them in the same size, say 256x256. or ask volunteers to do send image of the exact same resolution.
{ | ||
"name": "Nabarun Pal", | ||
"role": "Chair / Sponsorship Lead", | ||
"imagelink": "https://nabarun.dev/images/logo.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anistark Can we not host the images? If the source is gone, it will be lost here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 Yes, better to host images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last IIRC we used github profile images, I suggest using some gravatar or third-party integration then pushing so many images in the repo. I was actually very skeptical about the images we have pushed in this PR as well. Having a 3rd party URL lets the users have control over what images they want us to display.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that was also the reason the images disappeared after a while.
Better to have images as static asset than disappear later. Unless, its a solid link like an s3 or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anistark okay, but somehow I am not feeling comfortable hosting images like that. 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then can make sure the source is solid. Like if it's someone's personal website, it's their responsibility. But we might lose on history. Say in 10 years, its all blank boxes XD
If it's gravatar, should be fine. Gravatar won't disappear anytime soon. Hopefully! 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then for gravatar you would need profile to be created, correct?
hosting is the best solution but then I think we can just use GH as well.
}, | ||
{ | ||
"name": "Shabnam", | ||
"role": "Design & CoC WG Lead", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"role": "Design & CoC WG Lead", | |
"role": "Design & Code of Conduct WG Lead", |
}, | ||
{ | ||
"name": "Dhanush Kandhan", | ||
"role": "Technology", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technology WG?
}, | ||
{ | ||
"name": "Arthi Murali ", | ||
"role": "Communication WG", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I think now, since we are adding Lead to the leads, let's add volunteer for others.
"Communication WG Volunteer"
}, | ||
{ | ||
"name": "Arockiaraj Rayappan", | ||
"role": "Program Committee", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same! let's add WG to each for consistency
{ | ||
"name": "Kiritheka Dhanabalan", | ||
"role": "Program Committee", | ||
"imagelink": "/img/team/Kiritheka-Dhanabalan1.jpg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
absolute urls.
@@ -0,0 +1,142 @@ | |||
--- | |||
title: About the Team - PyCon India 2025 | |||
description: PyCon India is a volunteer driven conference. Like every year, we need enthusiastic and driven volunteer drive to make PyCon India successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"driven volunteer drive" was a tongue twister for me.
how about simplify to "PyCon India is a volunteer-driven conference. Like every year, we need enthusiastic and dedicated volunteers to help make it a success."
<!-- Left Content Section --> | ||
<div class="flex-1 max-w-2xl text-center lg:text-left"> | ||
<h1 class="text-3xl sm:text-4xl md:text-5xl lg:text-4xl font-bold text-white mb-4 sm:mb-6 lg:mb-8 leading-tight"> | ||
The Origin Story |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see any Origin Story?
</h2> | ||
|
||
<p class="text-base sm:text-lg md:text-xl lg:text-lg text-blue-50 leading-relaxed max-w-lg mx-auto lg:mx-0 mb-6 md:mb-8"> | ||
PyCon India is a volunteer driven conference. Like every year, we need enthusiastic and driven volunteer drive to make PyCon India successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mistakenly approved the last review, intended request changes
Hey Team! Also, quick check: are we hosting the images or using profile links? Need a answer on that. Once we have the active data, it’s just one commit away from wrapping this up.. |
No issues |
@dhanushk-offl you can use this for the volunteers information |
|
Okay let me make the changes. |
Here is the updated list of volunteers @dhanushk-offl |
Where's this stuck? |
I've provided the JSON. @dhanushk-offl has to integrate it in the PR. |
@dhanushk-offl are you still working on this? |
Hey Team, Sorry for inconvenience!! So can anyone share me the TL;DR |
Hey Team, Just a quick question: Since many volunteers don't have images, could we use a default image/avatar? Thoughts on this? If it's a good idea, can anyone get the image, or can we reuse the one from last year? @anistark, @farhaanbukhsh, and @ashish10677 - what are your thoughts? |
PR for Issue #115 – Add "About Us" Page 🎉
Summary of Changes:
about.njk
.main.css
and updatedtailwind.config.js
accordingly.