Removal of BAZEL build files from python package and changes to make cpp tests work #3641
+33
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apbose
changed the title
apbose
changed the title
apbose
changed the title
apbose
force-pushed
the
abose/package_remove_build
branch
from
356899f to
7024bf2
Compare
apbose
changed the title
Once the wheel is built, the Bazel files are no longer needed. Fixes #3477
apbose
force-pushed
the
abose/package_remove_build
branch
from
5f27f63 to
5eac5e5
Compare
narendasan
reviewed
Aug 1, 2025
third_party/BUILD
Outdated
| @@ -0,0 +1,53 @@ | |||
| load("@rules_cc//cc:cc_library.bzl", "cc_library") | |||
There was a problem hiding this comment.
Move this to `//third_party/torch_tensorrt/BUILD
narendasan
reviewed
Aug 1, 2025
docker/MODULE.bazel.ngc
Outdated
| name = "torch_tensorrt", | ||
| build_file = "@//third_party:BUILD", |
There was a problem hiding this comment.
Adjust this path accordingly
narendasan
reviewed
Aug 1, 2025
| @@ -613,8 +613,6 @@ def run(self): | |||
| package_data.update( | |||
| { | |||
| "torch_tensorrt": [ | |||
| "BUILD", | |||
| "WORKSPACE", | |||
| "include/torch_tensorrt/*.h", | |||
There was a problem hiding this comment.
Should we just delete the bzl folder now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #3615