Skip to content

feat: check the num of ILayer types and compare with ONNX-TRT in converter tests #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zewenli98
Copy link
Collaborator

Description

This PR enables checking the num of ILayer types and comparing with ONNX-TRT in converter tests.
To improve perf, we hope Torch-TRT to get the expected ILayer types for every single converter.
Since we observed on many models that ONNX-TRT generated TRT engines typically have better perf than Torch-TRT generated ones, to reduce perf gaps between Torch-TRT and ONNX-TRT, we introduce the mechanism to make sure Torch-TRT has the same num of ILayer types as ONNX-TRT.

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 requested review from narendasan and peri044 July 31, 2025 00:28
@zewenli98 zewenli98 self-assigned this Jul 31, 2025
@meta-cla meta-cla bot added the cla signed label Jul 31, 2025
@github-actions github-actions bot added the component: tests Issues re: Tests label Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant