-
Notifications
You must be signed in to change notification settings - Fork 23
[WIP] Upgrade issue templates #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pedrorrivero
wants to merge
2
commits into
main
Choose a base branch
from
issue-templates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,39 @@ | ||
| --- | ||
| name: 🐛 Bug report | ||
| about: Create a report to help us improve 🤔. | ||
| labels: bug | ||
| labels: [bug] | ||
| title: '' | ||
| assignees: '' | ||
| --- | ||
|
|
||
| <!-- ⚠️ If you do not respect this template, your issue will be closed --> | ||
| <!-- ⚠️ Make sure to browse the opened and closed issues --> | ||
|
|
||
| ### Steps to reproduce the problem | ||
| ### System information | ||
| <!-- Please, provide some information about your system for debugging purposes. --> | ||
| - Device: (e.g. MacBook Pro (16-inch, 2019)) | ||
| - OS: (e.g. macOS Monterey version 12.3.1) | ||
| - Python version: (e.g. 3.8.9) | ||
| - Prototype version: (e.g. 1.0.0) | ||
|
|
||
|
|
||
| ### What is the current behavior? | ||
| <!-- A clear and concise description of what the current behavior is. --> | ||
| <!-- If applicable, add screenshots to help explain your problem. --> | ||
|
|
||
|
|
||
| ### What is the expected behavior? | ||
| <!-- A clear and concise description of what you expected to happen. --> | ||
|
|
||
|
|
||
| ### Steps to reproduce the problem | ||
| <!-- Give some steps that show the bug. A minimal code example with output is best. --> | ||
| <!-- If you are copying in code, please remember to enclose it in triple backticks, ``` [multiline code goes here] ```, so that it displays correctly. --> | ||
|
|
||
|
|
||
| ### Additional context | ||
| <!-- Add any other context about the problem here if any. --> | ||
|
|
||
|
|
||
| ### Suggestions | ||
| <!-- Not required, but if you have suggestions for how a contributor should fix this, or any problems we should be aware of, let us know. --> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,13 @@ | ||
| --- | ||
| name: 💅 Enhancement request | ||
| about: Suggest an improvement for this project 🆒! | ||
| labels: 'type: enhancement' | ||
| labels: [enhancement] | ||
| title: '' | ||
| assignees: '' | ||
| --- | ||
|
|
||
| <!-- ⚠️ If you do not respect this template, your issue will be closed --> | ||
| <!-- ⚠️ Make sure to browse the opened and closed issues to confirm this idea does not exist. --> | ||
|
|
||
| ### What is the expected enhancement? | ||
|
|
||
| <!-- Please, provide a clear and concise description of the expected behavior for this enhancement. --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,13 @@ | ||
| --- | ||
| name: 🚀 Feature request | ||
| about: Suggest an idea for this project 💡! | ||
| labels: 'type: feature request' | ||
| labels: [feature] | ||
| title: '' | ||
| assignees: '' | ||
| --- | ||
|
|
||
| <!-- ⚠️ If you do not respect this template, your issue will be closed --> | ||
| <!-- ⚠️ Make sure to browse the opened and closed issues to confirm this idea does not exist. --> | ||
|
|
||
| ### What is the expected behavior? | ||
|
|
||
| <!-- Please, provide a clear and concise description of the expected behavior for this feature. --> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice if these examples were included in the HTML comment but not in the actual text. I could imagine people just submitting without modifying the text.
Also, can you think of a circumstance in which the device is relevant? It might be if they are running on POWER or Z or something, but for the most part I wouldn't expect it to be.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree! I'll take care of it.
Yeah, I see what you mean, however I don't think there is much harm in asking, just in case. It's probably not a huge effort for the user either. What do you think?