Skip to content

fix: example files with prompt in query param #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025

Conversation

AyushAgrawal-A2
Copy link
Collaborator

No description provided.

@AyushAgrawal-A2 AyushAgrawal-A2 self-assigned this Jun 18, 2025
@cla-bot cla-bot bot added the cla-signed label Jun 18, 2025
Copy link

qa-wolf bot commented Jun 18, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Contributor

github-actions bot commented Jun 18, 2025

Preview - Build, Deploy & Tests-E2E

✅ Build images
✅ Deploy images - Jun 18, 2025 at 07:02 PM UTC - Preview
❌ Tests-E2E - Report

@github-actions github-actions bot temporarily deployed to preview-pr-3096 June 18, 2025 17:54 Destroyed
teamUuid: string;
publicFileUrlInProduction: string;
additionalParams: string;
}) => `/teams/${teamUuid}/files/create?example=${publicFileUrlInProduction}&private${additionalParams}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publicFileUrlInProduction parameter should be URL-encoded to ensure special characters don't break the query string structure. Consider updating the code to:

`/teams/${teamUuid}/files/create?example=${encodeURIComponent(publicFileUrlInProduction)}&private${additionalParams}`

This prevents potential issues when the URL contains characters like &, ?, or = that have special meaning in query strings.

Suggested change
}) => `/teams/${teamUuid}/files/create?example=${publicFileUrlInProduction}&private${additionalParams}`,
}) => `/teams/${teamUuid}/files/create?example=${encodeURIComponent(publicFileUrlInProduction)}&private${additionalParams}`,

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (683a2b7) to head (a263aad).
Report is 14 commits behind head on qa.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #3096      +/-   ##
==========================================
- Coverage   91.07%   91.07%   -0.01%     
==========================================
  Files         401      401              
  Lines       93473    93473              
==========================================
- Hits        85128    85127       -1     
- Misses       8345     8346       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot temporarily deployed to preview-pr-3096 June 18, 2025 18:11 Destroyed
Copy link
Contributor

@luke-quadratic luke-quadratic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, tested:

  • file creation and prompt
  • file creation on its own
  • prompt creation on its own
  • private param

@AyushAgrawal-A2 AyushAgrawal-A2 merged commit 9e7a471 into qa Jun 19, 2025
166 of 187 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/example_with_prompt branch June 19, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants