-
Notifications
You must be signed in to change notification settings - Fork 236
fix: example files with prompt in query param #3096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
teamUuid: string; | ||
publicFileUrlInProduction: string; | ||
additionalParams: string; | ||
}) => `/teams/${teamUuid}/files/create?example=${publicFileUrlInProduction}&private${additionalParams}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The publicFileUrlInProduction
parameter should be URL-encoded to ensure special characters don't break the query string structure. Consider updating the code to:
`/teams/${teamUuid}/files/create?example=${encodeURIComponent(publicFileUrlInProduction)}&private${additionalParams}`
This prevents potential issues when the URL contains characters like &
, ?
, or =
that have special meaning in query strings.
}) => `/teams/${teamUuid}/files/create?example=${publicFileUrlInProduction}&private${additionalParams}`, | |
}) => `/teams/${teamUuid}/files/create?example=${encodeURIComponent(publicFileUrlInProduction)}&private${additionalParams}`, |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #3096 +/- ##
==========================================
- Coverage 91.07% 91.07% -0.01%
==========================================
Files 401 401
Lines 93473 93473
==========================================
- Hits 85128 85127 -1
- Misses 8345 8346 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, tested:
- file creation and prompt
- file creation on its own
- prompt creation on its own
- private param
No description provided.