Support rtl in floating.tsx #1109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bc50f0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
omerman
commented
Jun 14, 2025
| top: `${y}px`, | ||
| transform: context.transform, | ||
| }); | ||
| } | ||
|
|
||
| if (resolvedData.middlewareData.arrow && context.arrowRef?.value) { |
There was a problem hiding this comment.
I didnt yet add rtl support for the arrow but it doesnt seem to be working as expected with arrows at the given moment or at least didnt see a working example, so I ignored it atm.
|
I have read the CLA Document and I hereby sign the CLA |
omerman
force-pushed
the
fix/floating-rtl
branch
from
bf3ab99 to
f525f90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Why is it needed?
Support RTL layouts for all the floating elements, tooltips/popovers/dropdown etc..
Checklist:
pnpm changeand documented my changes