chore: update the storage doc flow #1024
Merged
+690
−359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Carter <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates and enhances documentation for various OpenStack Cinder backends and refines related Helm configuration files. Key changes include:
- Revamped operator guides for NetApp volume worker (both container and non-container versions) and LVM iSCSI deployment.
- Updated examples and step‑by‑step workflow sections, including detailed environment variable and helm override instructions.
- Adjustments to Helm override configurations with a new nova‑helm‑cinder‑overrides.yaml file and removal of redundant keys from nova‑helm‑overrides.yaml.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/openstack-cinder-netapp-worker.md | Updated operator guide with detailed workflow and configuration |
| docs/openstack-cinder-netapp-container.md | New container guide with BACKENDS variable examples and field mapping |
| docs/openstack-cinder-lvmisci.md | Enhanced LVM iSCSI guide with clearer checklists and steps |
| base-helm-configs/nova/nova-helm-overrides.yaml | Removed redundant volume_use_multipath key; streamlined settings |
| base-helm-configs/nova/nova-helm-cinder-overrides.yaml | Added new file to configure nova libvirt for cinder volume services |
Comments suppressed due to low confidence (1)
base-helm-configs/nova/nova-helm-overrides.yaml:152
- [nitpick] The removal of the 'volume_use_multipath' key from this file may lead to confusion if it is expected by downstream configurations; please confirm that this change is intentional and ensure that consistency is maintained across the Helm override files.
volume_use_multipath: false
aedan
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.