Skip to content

Added ability to pass step amount for minutes value #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hamzahalhariri
Copy link

@hamzahalhariri hamzahalhariri commented Jun 14, 2019

So the idea here is that i want to "add" or "take a way" a specific amount of minutes, basically add a jump steps
For example: add 15 mins every time i press on "arrow up" key when i have the caret on minutes group

const value = "12:00 AM"
<TimeInput value={value} step={15} onChange={onChange}/>
// expected the output when "key up" pressed
// while the caret is positioned in minutes group to be: "12:15 AM"

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #8 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   96.34%   96.57%   +0.22%     
==========================================
  Files          12       12              
  Lines         164      175      +11     
  Branches       49       51       +2     
==========================================
+ Hits          158      169      +11     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
src/TimeInput.js 95.31% <100%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc98738...7ef5f9d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant