Skip to content

Support for configuration of color for skipped tests via environment variable #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jonasbn
Copy link
Contributor

@jonasbn jonasbn commented Mar 8, 2020

Hello,

I have made an attempt at support for configuration of the color for skipped tests using the environment variable as a third parameter.

I have also updated the documentation since I thought it was a bit sparse.

I am very new to Go so please bare with me if I have made some basic mistakes. I hope you will consider my mediocre contribution.

Copy link
Contributor

@subtlepseudonym subtlepseudonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicky copy changes (not blockers) and one code change

Co-authored-by: Connor Demille <[email protected]>
@jonasbn
Copy link
Contributor Author

jonasbn commented Jun 8, 2020

Updated from master with the latest releases, conflicts resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants