Skip to content

!WIP fix: fix balance not updating on fetching balance with different wallet types #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

RyukTheCoder
Copy link
Collaborator

Summary

The fetchBalance function previously assumed it would only be called with a single walletType, leading to potential issues when triggered by the 'refetch all' button in the dapp. This pull request eliminates that assumption, resolving the problems associated with the 'refetch all' feature.

Fixes # (issue)

How did you test this change?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@RyukTheCoder RyukTheCoder changed the title fix: fix balance not updating on fetching balance with different wallet types !WIP fix: fix balance not updating on fetching balance with different wallet types Feb 26, 2025
@RanGojo RanGojo requested a review from yeager-eren March 5, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants