Adds auto selection of cracker for password crackers

[H4k1l]

Description

The changes satisfy the requests made in issue number #20396.

The first change was made in the file “lib/metasploit/framework/password_crackers/cracker.rb”
to the “binary_path” function. In the issue, the user reported that if John The Ripper was not detected by Metasploit, it would not check if Hashcat was installed, so I modified the function so that there are four concatenated if statements rather than an if-elsif-else statement.

The second change is in “modules/auxiliary/analyze/” in the files:

• crack_aix.rb
• crack_databases.rb
• crack_linux.rb
• crack_osx.rb
• crack_webapps.rb
• crack_windows.rb

They received the same change with the same implementation. I added an action, “auto.” If this action is used, the module will see if either Hashcat or John The Ripper is installed and will choose one of the two, preferring Hashcat.

Verification

• Start msfconsole
• use auxiliary/analyze/crack_databases
• set action auto
• Insert something to crack(example: creds add user:test_user postgres:md55d41402abc4b2a76b9719d911017c592
• run

[msutovsky-r7]

This just does exactly what is in cracker.rb - I think we should keep the logic there and not move it separately into each module.

[msutovsky-r7]

Suggested change

	['auto', { 'Description' => 'Auto-selection of cracker' ]}
	['auto', { 'Description' => 'Auto-selection of cracker' }]

[msutovsky-r7]

Release Notes

Updates the password cracking modules to now automatically detect the presence of JohnTheRipper or Hashcat binaries on the host filesystem when attempting to crack credentials.