Skip to content

Remove unnecessary dependencies #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025
Merged

Remove unnecessary dependencies #221

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53b4e1d
Remove unnecessary dependencies
rashidi Mar 27, 2025
f73a25c
Remove unnecessary dependencies
rashidi Mar 27, 2025
c49e6ea
Remove unnecessary dependencies
rashidi Mar 27, 2025
a258da2
Remove unnecessary dependencies
rashidi Mar 27, 2025
aee0b26
Remove unnecessary dependencies
rashidi Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cloud-jdbc-env-repo/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@ ext {
}

dependencies {
implementation platform("org.springframework.cloud:spring-cloud-dependencies:${springCloudVersion}")

implementation 'org.springframework.boot:spring-boot-starter-data-jdbc'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Moving spring-cloud-dependencies from here...

Is this intentional? Moving the dependency declaration to dependencyManagement changes how dependencies are resolved. Please confirm this is the desired behavior and that all dependencies are still being resolved correctly.

implementation 'org.springframework.cloud:spring-cloud-starter-bootstrap'
implementation 'org.springframework.cloud:spring-cloud-starter-bootstrap'
implementation 'org.springframework.cloud:spring-cloud-config-server'
runtimeOnly 'com.mysql:mysql-connector-j'
annotationProcessor 'org.springframework.boot:spring-boot-configuration-processor'
Expand All @@ -41,6 +39,12 @@ dependencies {
testImplementation 'org.testcontainers:mysql'
}

dependencyManagement {
imports {
mavenBom "org.springframework.cloud:spring-cloud-dependencies:${springCloudVersion}"
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

...to here. This centralizes the dependency versions. Ensure that this change doesn't negatively impact dependency resolution or introduce conflicts.


tasks.named('test') {
useJUnitPlatform()
}
Loading