Skip to content

Add option for download update file name. #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nhanchaukp
Copy link

In some cases, updates need to be downloaded from URLs that do not contain a properly formatted file name.
For example:
https://example.com/download/aW90L2lvdHNvZnR3YXJlLzIwMjUvMDIvMjYvMTc0MDU3NDg1MjQ3OC56aXA=

In this case, the Content-Disposition header in the response must be used to determine the file name. However, if it is missing, the downloaded file will be saved as aW90L2lvdHNvZnR3YXJlLzIwMjUvMDIvMjYvMTc0MDU3NDg1MjQ3OC56aXA=, which can cause issues. For example, it may not be possible to extract the file (if it lacks a .zip extension) or execute it (if it lacks a .exe extension), leading to an update failure.

In this update, users can manually specify the desired file name using UpdateInfoEventArgs.DownloadFileName.
For example:

UpdateInfoEventArgs.DownloadFileName = "Update.zip";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant