-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[Core] Bind runtime env agent and dashboard agent server to specified ip instead of 0.0.0.0 #55431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Core] Bind runtime env agent and dashboard agent server to specified ip instead of 0.0.0.0 #55431
Conversation
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avibasnet31 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @avigyabb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've made changes to how several Ray components bind to network interfaces. Previously, some services would conditionally bind to 0.0.0.0 (listening on all interfaces) or 127.0.0.1. This pull request streamlines this behavior by ensuring these services explicitly bind to the specific node's IP address. This change aims to improve clarity and potentially enhance security by ensuring services only listen on the intended interface.
Highlights
- Runtime Environment Agent Host Binding: The runtime_env_agent now binds its web application to args.node_ip_address directly, removing the previous logic that would bind to 0.0.0.0 if the node IP was not 127.0.0.1.
- Dashboard Agent gRPC Host Binding: The dashboard_agent's gRPC server now binds to self.ip instead of a conditional 0.0.0.0 or 127.0.0.1. The logging for the gRPC address has also been updated to reflect this change.
- Dashboard HTTP Server Agent Host Binding: The http_server_agent now binds its HTTP server to self.ip, eliminating the previous conditional logic that would bind to 0.0.0.0 if the IP was not 127.0.0.1.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors network service binding in the runtime environment and dashboard agents. It removes the logic that defaults to binding on all interfaces (0.0.0.0
) and instead binds directly to the provided node_ip_address
. This change improves security by default by scoping services to a specific network interface and makes the behavior more predictable. The modifications are consistently applied and well-implemented. I approve of these changes.
Signed-off-by: avibasnet31 <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Why are these changes needed?
For better security practice, we want to avoid having our servers listening to all interfaces and instead bind to localhost and an external interface if one is passed in.
Changed conditional logic from binding to all interfaces to only the IP that is passed in. If the IP is external, then have servers bind to localhost as well.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.