Skip to content

[Core] Bind runtime env agent and dashboard agent server to specified ip instead of 0.0.0.0 #55431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

avigyabb
Copy link
Contributor

@avigyabb avigyabb commented Aug 8, 2025

Why are these changes needed?

For better security practice, we want to avoid having our servers listening to all interfaces and instead bind to localhost and an external interface if one is passed in.

Changed conditional logic from binding to all interfaces to only the IP that is passed in. If the IP is external, then have servers bind to localhost as well.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @avigyabb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've made changes to how several Ray components bind to network interfaces. Previously, some services would conditionally bind to 0.0.0.0 (listening on all interfaces) or 127.0.0.1. This pull request streamlines this behavior by ensuring these services explicitly bind to the specific node's IP address. This change aims to improve clarity and potentially enhance security by ensuring services only listen on the intended interface.

Highlights

  • Runtime Environment Agent Host Binding: The runtime_env_agent now binds its web application to args.node_ip_address directly, removing the previous logic that would bind to 0.0.0.0 if the node IP was not 127.0.0.1.
  • Dashboard Agent gRPC Host Binding: The dashboard_agent's gRPC server now binds to self.ip instead of a conditional 0.0.0.0 or 127.0.0.1. The logging for the gRPC address has also been updated to reflect this change.
  • Dashboard HTTP Server Agent Host Binding: The http_server_agent now binds its HTTP server to self.ip, eliminating the previous conditional logic that would bind to 0.0.0.0 if the IP was not 127.0.0.1.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors network service binding in the runtime environment and dashboard agents. It removes the logic that defaults to binding on all interfaces (0.0.0.0) and instead binds directly to the provided node_ip_address. This change improves security by default by scoping services to a specific network interface and makes the behavior more predictable. The modifications are consistently applied and well-implemented. I approve of these changes.

avibasnet31 and others added 5 commits August 8, 2025 13:49
Signed-off-by: avibasnet31 <[email protected]>
Signed-off-by: avigyabb <[email protected]>
@avigyabb avigyabb changed the title Avigyabb/eliminate listen all ports 2 [Core] Bind runtime env agent and dashboard agent server to specified ip instead of 0.0.0.0 Aug 12, 2025
@avigyabb avigyabb marked this pull request as ready for review August 12, 2025 17:03
@avigyabb avigyabb requested a review from a team as a code owner August 12, 2025 17:03
@ray-gardener ray-gardener bot added community-contribution Contributed by the community core Issues that should be addressed in Ray Core security The issue or proposal related to security labels Aug 12, 2025
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Aug 12, 2025
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Signed-off-by: avigyabb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Contributed by the community core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests security The issue or proposal related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants