Skip to content

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 20, 2025

Infer the build length by using the first command's start time.

Infer the build length by using the first command's start time.
@humitos humitos requested a review from a team as a code owner August 20, 2025 09:14
@humitos humitos requested a review from ericholscher August 20, 2025 09:14
@humitos
Copy link
Member Author

humitos commented Aug 20, 2025

I found we want to use the same logic in the ext-theme as well: readthedocs/ext-theme#644

@ericholscher
Copy link
Member

I wonder if we should put -1 or something for build length, since it's a failure mode, and then display something different in the UI?

@humitos
Copy link
Member Author

humitos commented Aug 20, 2025

That's also a good point. Currently, the Build.length=None when the build is terminated. However, the UI is showing detecting that as a special case and showing a dynamic time based on Build.date which is not accurate (I opened an issue about that). Maybe fixing that issue in the template is all we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants