[WIP] hitless #3447
Draft
[WIP] hitless #3447
+6,706
−246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndyakov
force-pushed
the
ndyakov/CAE-1072-hitless-upgrades-2
branch
2 times, most recently
from
49e5814 to
43aef14
Compare
ndyakov
changed the base branch from
ndyakov/CAE-1088-resp3-notification-handlers
to
master
ndyakov
force-pushed
the
ndyakov/CAE-1072-hitless-upgrades-2
branch
21 times, most recently
from
8608f93 to
a39a23a
Compare
ndyakov
force-pushed
the
ndyakov/CAE-1072-hitless-upgrades-2
branch
2 times, most recently
from
e88e673 to
4542e8f
Compare
ndyakov
changed the base branch from
master
to
ndyakov/CAE-1088-resp3-notification-handlers
ndyakov
force-pushed
the
ndyakov/CAE-1072-hitless-upgrades-2
branch
3 times, most recently
from
9590c26 to
100c3d2
Compare
ndyakov
force-pushed
the
ndyakov/CAE-1072-hitless-upgrades-2
branch
3 times, most recently
from
ed9b281 to
08516d4
Compare
ndyakov
force-pushed
the
ndyakov/CAE-1072-hitless-upgrades-2
branch
from
08516d4 to
34edec2
Compare
ndyakov
force-pushed
the
ndyakov/CAE-1072-hitless-upgrades-2
branch
from
e3b4e8d to
6d61830
Compare
ndyakov
force-pushed
the
ndyakov/CAE-1072-hitless-upgrades-2
branch
from
6d61830 to
a4090d4
Compare
ndyakov
force-pushed
the
ndyakov/CAE-1072-hitless-upgrades-2
branch
from
0c5e583 to
0091c74
Compare
ndyakov
force-pushed
the
ndyakov/CAE-1072-hitless-upgrades-2
branch
from
bd02c37 to
d3c3eb7
Compare
ndyakov
force-pushed
the
ndyakov/CAE-1072-hitless-upgrades-2
branch
from
8e73688 to
aabfdaa
Compare
ndyakov
commented
Aug 17, 2025
| go func() { | ||
| time.Sleep(time.Duration(timeS/2) * time.Second) | ||
| if err := snh.markConnForHandoff(poolConn, newEndpoint, seqID, deadline); err != nil { | ||
| // Log error but don't fail the goroutine |
There was a problem hiding this comment.
check conn existence before that, make sure it is not closed
ndyakov
commented
Aug 17, 2025
| // delay the handoff for timeS/2 seconds to the same endpoint | ||
| // do this in a goroutine to avoid blocking the notification handler | ||
| go func() { | ||
| time.Sleep(time.Duration(timeS/2) * time.Second) |
There was a problem hiding this comment.
maybe we can use "last used at" for better calculation here? It won't be correct to determine when the connection was last used, but we can try.
ndyakov
commented
Aug 18, 2025
| @@ -29,7 +29,7 @@ test.ci: | |||
| (cd "$${dir}" && \ | |||
| go mod tidy -compat=1.18 && \ | |||
| go vet && \ | |||
| go test -v -coverprofile=coverage.txt -covermode=atomic ./... -race -skip Example); \ | |||
| go test -v -coverprofile=coverage.txt -covermode=atomic ./... -race -timeout 20m -skip Example); \ | |||
There was a problem hiding this comment.
can be returned to 10m (by default)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.