Skip to content

Using non-native transports with SocketOptions should cause an error #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thachlp
Copy link
Contributor

@thachlp thachlp commented Apr 26, 2025

Isssue #3251

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@tishun tishun added this to the 7.0.0.RELEASE milestone May 9, 2025
@tishun
Copy link
Collaborator

tishun commented May 9, 2025

This is an interesting approach, but it does not fully cover the different invariants.

The logic that outputs warnings in the log is in the ConnectionBuilder.java class.

As you can see only io_uring and epoll support TCP_USER_TIMOUT, while io_uring, epoll the extended socket options in Java 11 support TCP_KEEP_ALIVE / TCP_KEEPIDLE and TCP_KEEPINTERVAL.

I was thinking of replacing the log message with the LettuceAssert.assertState that is already used there.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants