Skip to content

DOC-5375 reactive hash examples #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Jun 26, 2025

Make sure that:

  • You have read the contribution guidelines.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

DOC-5375

Reactive examples for the hash doc page. Also fixed what I think is an incorrectly-placed REMOVE_START in the existing strings example.

Note: this is my first reactive example, so I'm not sure of the best style, etc. In particular:

  • Does it look OK to have the block() calls visible in some of the examples? We could hide them, but I'm wondering if it emphasises that you have to wait for a command like hset to complete before you can hget the values it has set.
  • I've used flatMap only when there is a strict sequence of operations (like with the chain of dependent hincr calls in the last example) rather than use it to recreate the exact sequence used in the equivalent Jedis examples.

Any other suggestions or corrections would be very welcome :-)

@andy-stark-redis andy-stark-redis marked this pull request as ready for review June 26, 2025 13:15
@tishun tishun added this to the Async milestone Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants