-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add support for Trio via AnyIO #3647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
What is the Python version support policy in this project? I see that v6.0.0 was released with Python 3.8 support even though it reached its end of life last year. |
…om_url() The test is synchronous but really requires a running event loop.
Hi @agronholm, thank you for your contribution! We will have a look at it soon. |
Any updates on that? |
Would love to see this get added! |
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This adds an alternate, AnyIO based asynchronous client. This is necessary in order to make it possible for users of the Trio async framework to use Redis asynchronously. But the potential does not end there. Given that AnyIO supports asyncio as well, it would be possible to later replace the asyncio client with the AnyIO one.
A minor improvement would also be to remove
pytest-asyncio
from test dependencies and just use the AnyIO test plugin for testing both the AnyIO and asyncio clients.A few things to note:
redis-entraid
is a separate library with asyncio-only async code, I had to limit tests involving that to only run on asyncio. I could also migrate that library as follow-up work.