-
Notifications
You must be signed in to change notification settings - Fork 2
Add a Let's Encrypt SSL cert renewal script and cronjob #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eployment process
… env var echo lines.
…ate all nginx-related directories.
…update nginx related files and directories
Bypassing PR review rules since this is a timely fix to land and Claude gave a helpful an comprehensive PR review of with suggestions implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a Let's Encrypt SSL cert renewal script, installs it into the deployment process, and sets up a cronjob to run this script twice a day.
GitHub Issue: N/A
Changes
Testing Strategy
Test the deployment updates by changing the production env var
BACKEND_IMAGE_NAME
toghcr.io/refactor-group/refactor-platform-rs/improve_lets_encrypt_ssl_cert_renewal:latest
Kick off a deployment from GitHub Actions making sure to deploy with the branch
improve_lets_encrypt_ssl_cert_renewal
Test the renewal script in dry-run mode (won't actually renew, just checks):
sudo certbot renew --webroot -w ./nginx/html --dry-run
If that works, test your actual renewal script:
./nginx/scripts/renew-certs.sh
Check that the log file was created:
cat nginx/logs/letsencrypt-renewal.log
Verify nginx is still running and serving your site:
BACKEND_IMAGE_NAME
back toghcr.io/refactor-group/refactor-platform-rs/main:latest
Concerns
None