Skip to content

MAILERSEND_API_KEY should be set as a secret, not an env var #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

MAILERSEND_API_KEY should be set as a secret, not an env var #183

merged 1 commit into from
Aug 12, 2025

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Aug 12, 2025 •
edited
Loading

Description

This PR fixes the issue preventing new user email sending from working.

GitHub Issue: None

Changes

  • Change MAILERSEND_API_KEY to be a GitHub secret

Testing Strategy

  1. Create a new user under an org
  2. This user should receive a new welcome email from [email protected]

Concerns

None

@jhodapp jhodapp added this to the 1.0.0-beta2 milestone Aug 12, 2025
@jhodapp jhodapp requested a review from calebbourg August 12, 2025 22:54
@jhodapp jhodapp self-assigned this Aug 12, 2025
@jhodapp jhodapp added the bug fix Contains a fix to a known bug label Aug 12, 2025
@jhodapp jhodapp merged commit 1ba3569 into main Aug 12, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Review to ✅ Done in Refactor Coaching Platform Aug 12, 2025
@jhodapp jhodapp deleted the fix_mailersend_api_key_deployment_issue branch August 12, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebbourg calebbourg Awaiting requested review from calebbourg

Assignees

@jhodapp jhodapp

Labels
bug fix Contains a fix to a known bug
Projects
Refactor Coaching Platform
Status: ✅ Done
Milestone
1.0.0-beta2
Development

Successfully merging this pull request may close these issues.
1 participant
@jhodapp