`@rescript/runtime` package #7796

cknitt · 2025-08-24T08:59:43Z

This builds on @cometkim's work in #7483 to extract the runtime files from the main rescript package into a new package @rescript/runtime, resolving a part of #6183.

Removal of @rescript/std shall be done in a separate PR.

# Conflicts: # cli/common/bsb.js

pkg-pr-new · 2025-08-24T10:45:51Z

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7796

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7796

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7796

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7796

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7796

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7796

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7796

commit: 5f4e6aa

nojaf · 2025-08-25T06:29:57Z

So, how would this work? I install rescript, and @rescript/runtime is installed as well?
Initial compile will do the one time compilation of the runtime?
A rescript clean never cleans the runtime?

I was expecting a package.json in packages/@rescript/runtime, don't we need that?

cknitt · 2025-08-25T06:36:01Z

So, how would this work? I install rescript, and @rescript/runtime is installed as well?

Yes, it's installed automatically as a dependency of the rescript package, like the bin package for the platform.

Initial compile will do the one time compilation of the runtime? A rescript clean never cleans the runtime?

No, it is precompiled like it was before, nothing changed there. Only the artifacts (lib/ocaml, lib/es6, lib/js) are moved from the rescript package to the new @rescript/runtime package.

I was expecting a package.json in packages/@rescript/runtime, don't we need that?

It's there: https://github.com/rescript-lang/rescript/blob/runtime-package/packages/%40rescript/runtime/package.json

nojaf · 2025-08-25T06:55:39Z

I see, this is more of a first step in a larger plan.

mediremi · 2025-08-26T08:34:46Z

Will not including res(i) files in @rescript/runtime break "go to definition" for stdlib functions?

cknitt · 2025-08-26T08:53:31Z

Will not including res(i) files in @rescript/runtime break "go to definition" for stdlib functions?

Maybe the commit message was not good, the last commit just prevents them from being included in the package root in addition to lib/ocaml. They are not really required in the package root. "Go to definition" jumps to the source files in lib/ocaml.

zth · 2025-08-26T10:16:16Z

analysis/src/FindFiles.ml

@@ -142,7 +142,7 @@ let findProjectFiles ~public ~namespace ~path ~sourceDirectories ~libBs =
  in
  let files =
    dirs |> StringSet.elements
-    |> List.map (fun name -> Files.collect name isSourceFile)
+    |> List.map (fun name -> Files.collect ~maxDepth:2 name isSourceFile)


Curious, why is a maxDepth needed after this PR?

This part is from @cometkim.

From what I have seen, infinite recursion can occur during module resolution without it because rescript depends on @rescript/runtime, but @rescript/runtime also has rescript as a dev dependency.

Maybe we should add a comment there.

Yeah a comment would be good.

cristianoc

Just a minor Q: is "lib/ocaml" something we want to rename here, or perhaps later to keep changes self contained.
Unless it's the correct name for some legacy reason or other tooling back comp.

cknitt · 2025-08-26T13:31:49Z

Just a minor Q: is "lib/ocaml" something we want to rename here, or perhaps later to keep changes self contained. Unless it's the correct name for some legacy reason or other tooling back comp.

Would be nice to change the name of this folder, but I think this is outside the scope of this PR and will also most probably break some tooling.

cometkim · 2025-08-26T14:32:49Z

analysis/src/ModuleResolution.ml

-  if Files.exists path then Some path
-  else if Filename.dirname startPath = startPath then None
-  else resolveNodeModulePath ~startPath:(Filename.dirname startPath) name
+  if name = "@rescript/runtime" then


I don't remember exactly, but this is incomplete code. I think this is incompatible with the external-stdlib feature already.

I tried rewriting it to avoid relying on ninja's special stdlib resolution rules, but I wasn't successful. The current resolution rules still heavily rely on the node_modules directory structure and the runtime package name, which could be broken by package managers' storage design.

Yes, the module resolution in analysis/tools definitely has issues and should be revisited.

It does not work with workspace dependencies as can be seen here and also in #7525.

/cc @zth

I don't know much about the module resolution. What's the problem? Is it problem we handle as we should elsewhere but not in analysis/tools?

cometkim and others added 18 commits August 24, 2025 07:23

move minisocket.js

fc76a2e

# Conflicts: # cli/common/bsb.js

move runtime codes

d75ee7e

move runtime artifacts

a73ec3d

new runtime resolution

9648a04

fix ci

d9eb323

clean-lib-bsb

6d4021a

yarn constraints --fix

f898991

move cppo script

8e3323e

fix a diff script in ci workflow

d6aa620

update artifacts

f9188db

remove an unused import mapping

0565afa

sync gentype results

3a4a9d8

Format some files

488edeb

Fix rewatch tests

99382ad

Bring back advanced logic for finding runtime path

6366814

Hack to fix finding runtime module in analysis/tools

68bfe78

Fix package name for tools test

e2a9bf9

Fix playground build

fb158d9

cknitt force-pushed the runtime-package branch from 893b57d to fb158d9 Compare August 24, 2025 09:23

cknitt added 3 commits August 24, 2025 11:30

Improve build step names

abe93b6

Fix apidocs generation

e829f7a

Remove buildRuntime.sh

f014e59

cknitt force-pushed the runtime-package branch 2 times, most recently from 9a5d72b to 4d7b90d Compare August 24, 2025 10:17

Fix pkg-pr-new

78b6bfe

cknitt force-pushed the runtime-package branch from 4d7b90d to 78b6bfe Compare August 24, 2025 11:07

Fix pnpm

ef1d4ef

cknitt marked this pull request as ready for review August 24, 2025 12:08

cknitt requested a review from cristianoc August 24, 2025 12:09

cknitt requested a review from zth August 24, 2025 12:09

CHANGELOG

b9f8e3f

cknitt force-pushed the runtime-package branch from 12150c9 to b9f8e3f Compare August 25, 2025 04:02

Do not include *.res(i) in the runtime files

5165128

zth reviewed Aug 26, 2025

View reviewed changes

cristianoc approved these changes Aug 26, 2025

View reviewed changes

Add comment

5f4e6aa

cknitt merged commit bfec8a2 into master Aug 26, 2025
48 of 49 checks passed

cknitt deleted the runtime-package branch August 26, 2025 13:47

cometkim reviewed Aug 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`@rescript/runtime` package #7796

`@rescript/runtime` package #7796

Uh oh!

cknitt commented Aug 24, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Aug 24, 2025 •

edited

Loading

Uh oh!

nojaf commented Aug 25, 2025

Uh oh!

cknitt commented Aug 25, 2025

Uh oh!

nojaf commented Aug 25, 2025

Uh oh!

mediremi commented Aug 26, 2025

Uh oh!

cknitt commented Aug 26, 2025

Uh oh!

zth Aug 26, 2025

Uh oh!

cknitt Aug 26, 2025

Uh oh!

zth Aug 26, 2025

Uh oh!

cristianoc left a comment •

edited

Loading

Uh oh!

cknitt commented Aug 26, 2025

Uh oh!

Uh oh!

cometkim Aug 26, 2025

Uh oh!

cknitt Aug 26, 2025

Uh oh!

zth Aug 26, 2025

Uh oh!

Uh oh!

@rescript/runtime package #7796

@rescript/runtime package #7796

Uh oh!

Conversation

cknitt commented Aug 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Aug 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nojaf commented Aug 25, 2025

Uh oh!

cknitt commented Aug 25, 2025

Uh oh!

nojaf commented Aug 25, 2025

Uh oh!

mediremi commented Aug 26, 2025

Uh oh!

cknitt commented Aug 26, 2025

Uh oh!

zth Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

cknitt Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

zth Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

cristianoc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cknitt commented Aug 26, 2025

Uh oh!

Uh oh!

cometkim Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

cknitt Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

zth Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

`@rescript/runtime` package #7796

`@rescript/runtime` package #7796

cknitt commented Aug 24, 2025 •

edited

Loading

pkg-pr-new bot commented Aug 24, 2025 •

edited

Loading

cristianoc left a comment •

edited

Loading