-
Notifications
You must be signed in to change notification settings - Fork 640
refactor: remove col_index_mapping
when replacing table
#21685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bz/dispatcher-output-mapping-rewrite-index
Are you sure you want to change the base?
refactor: remove col_index_mapping
when replacing table
#21685
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
19486df
to
e151155
Compare
5a1b638
to
ff20219
Compare
e151155
to
5277b6b
Compare
ff20219
to
9c4fd0f
Compare
5277b6b
to
892cb56
Compare
9c4fd0f
to
e7b889e
Compare
892cb56
to
a178ce1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the now-unnecessary col_index_mapping parameter and related logic from table replacement handling. Key changes include removing the use of ColIndexMapping in multiple modules (RPC client, meta, and frontend) as well as updating proto definitions accordingly.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/rpc_client/src/meta_client.rs | Removed ColIndexMapping usage from replace_job and related calls |
src/meta/src/rpc/ddl_controller.rs | Eliminated col_index_mapping parameter from job replacement API |
src/meta/src/controller/streaming_job.rs | Removed col_index_mapping parameters in job finishing methods |
src/meta/service/src/ddl_service.rs | Dropped col_index_mapping processing in extracting replace table info |
src/frontend (various files) | Updated function signatures and calls to omit col_index_mapping |
proto/ddl_service.proto | Removed table_col_index_mapping field from proto request messages |
Comments suppressed due to low confidence (2)
src/rpc_client/src/meta_client.rs:642
- Since ColIndexMapping is no longer needed in the ReplaceJobPlanRequest, ensure that all internal and external documentation is updated to reflect that this parameter is removed.
table_col_index_mapping: ColIndexMapping,
proto/ddl_service.proto:372
- Remove or update comments referencing table_col_index_mapping so that the proto definition clearly reflects the new API without this field.
catalog.ColIndexMapping table_col_index_mapping = 2;
e7b889e
to
f7de5e4
Compare
a178ce1
to
2ed7553
Compare
f7de5e4
to
86eb5d7
Compare
2ed7553
to
0a3cc8a
Compare
86eb5d7
to
4696b1c
Compare
0a3cc8a
to
1534733
Compare
Signed-off-by: Bugen Zhao <[email protected]>
1534733
to
9a9f63c
Compare
4696b1c
to
a193a49
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#21499 eliminated the need for using
ColIndexMapping
for deriving the dispatcher after replacing a table. In last PR (#21681), we further eliminated the need for using it to rewrite the indexes. As a result, we can remove this field from the request ofReplaceTable
now.Checklist
Documentation
Release note