-
Notifications
You must be signed in to change notification settings - Fork 640
test: add integration test for logstore scale-in / out #21781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
||
[meta] | ||
meta_leader_lease_secs = 10 | ||
max_heartbeat_interval_secs = 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from ci-sim
, but with this additional configuration, to force worker node to be evicted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this heartbeat value was too large previously, should we set this value directly in the origin ci-sim
and reuse the same config file so that more corner case can be tested in the integration tests and recovery tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, we can change it in a subsequent PR to avoid scope creep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 5711 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
2397 | 1 | 3313 | 0 |
Click to see the invalid file list
- src/tests/simulation/tests/integration_tests/log_store/utils.rs
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
@@ -27,27 +27,7 @@ use risingwave_simulation::cluster::{Cluster, ConfigPath, Configuration, KillOpt | |||
use risingwave_simulation::ctl_ext::predicate::identity_contains; | |||
use tokio::time::sleep; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored utilies from this file to utils.rs
|
||
[meta] | ||
meta_leader_lease_secs = 10 | ||
max_heartbeat_interval_secs = 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this heartbeat value was too large previously, should we set this value directly in the origin ci-sim
and reuse the same config file so that more corner case can be tested in the integration tests and recovery tests?
9d778c0
to
47485a5
Compare
Mark as draft, so we can just test the scale-in test. |
e2505a8
to
d7ec856
Compare
024e422
to
76056fd
Compare
f79c380
to
fce6930
Compare
fce6930
to
c078236
Compare
76056fd
to
7863c52
Compare
c078236
to
fce6930
Compare
25cc76d
to
1c870ed
Compare
1c870ed
to
69c7538
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Last part of unaligned join #20408.
Kill some nodes, wait for worker to be expired, which triggers scale-in. Restart the worker nodes after scale-in, to trigger scale-out again.
Finally, check that the data in the logstore is correct.
Checklist
Documentation
Release note