refactor(ci): move pyarrow from ci image to test scripts
#21804
Merged
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Chien <[email protected]>
stdrc
changed the title
pyarrow from ci image to test scriptspyarrow from ci image to test scripts
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the handling of the pyarrow dependency by moving its installation from the CI image build into the test scripts, ensuring future compatibility. Key changes include:
- Bumping arrow_udf version in the UDF requirements file.
- Adding a new S3 requirements file with pyarrow and related dependencies.
- Updating CI test scripts and the Dockerfile to install dependencies via requirements files instead of inline.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| e2e_test/udf/remote_python/requirements.txt | Updated arrow_udf version to 0.3.1. |
| e2e_test/s3/requirements.txt | Added dependencies (pyarrow, minio, psycopg2-binary, opendal, pandas) for S3 tests. |
| ci/scripts/slow-e2e-test.sh | Changed dependency installation to use the UDF requirements file. |
| ci/scripts/s3-source-test.sh | Changed dependency installation to use the S3 requirements file. |
| ci/Dockerfile | Removed pyarrow installation to defer dependency management to test scripts. |
| ci/.env | Updated the BUILD_ENV_VERSION to a more recent value. |
Signed-off-by: Richard Chien <[email protected]>
xxchan
approved these changes
May 10, 2025
BugenZhao
approved these changes
May 12, 2025
| @@ -58,6 +58,10 @@ steps: | |||
| - monorepo-diff#v1.2.0: | |||
| diff: "git diff --name-only origin/main" | |||
| watch: | |||
| - path: "ci/.env" | |||
There was a problem hiding this comment.
Shall we merge the path?
https://github.com/adikari/monorepo-diff-buildkite-plugin#path
A list of paths can be provided to trigger the desired pipeline. Changes in any of the paths will initiate the pipeline provided in trigger.
There was a problem hiding this comment.
Let's do it when there're 3 paths 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Move
pyarrowpackage installation from CI image building to test shell script, to avoid future incompatibility.Checklist
Documentation
Release note