[Python] Don't include JsMVA in builds #19040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
requested review from
bellenot,
dpiparo and
vepadulano
as code owners
These files should not leave the source tree.
The JsMVA package is undocumented, untested, and lagging behind in terms of the JsROOT version that it uses. At this point, there is no clear reason for including it in the ROOT builds, so this commit suggests to remove it from the build and install tree temporarily, until we are sure that it works (also with the newest JsROOT version).
guitargeek
force-pushed
the
disable_jsmva
branch
from
05aa7c4 to
6373e07
Compare
Test Results 19 files 19 suites 3d 9h 15m 3s ⏱️ For more details on these failures, see this check. Results for commit 6373e07. |
dpiparo
approved these changes
Jun 14, 2025
|
That's hard to say. The only information I could find about this package are these GSoC presentations (it was a GSoC project mentored by @etejedor):
The maintenance inside ROOT is challenging because it's the only JavaScript code in ROOT that is not maintained by @linev. Indeed, it might be easier to ship it as a small Python package on PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JsMVA package is undocumented, untested, and lagging behind in terms
of the JsROOT version that it uses.
At this point, there is no clear reason for including it in the ROOT
builds, so this commit suggests to remove it from the build and install
tree temporarily, until we are sure that it works (also with the newest
JsROOT version).
Alternative to #12484.
Closes #12441.