[ntuple] Fixes to iterators #19728
Open
[ntuple] Fixes to iterators #19728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These cannot be forward iterators because of clause 24.3.5.5.6 in the C++ standard (see also https://eel.is/c++draft/forward.iterators#6): > If a and b are both dereferenceable, then a == b if and only if *a > and *b are bound to the same object. We cannot make this happen for member objects of the iterator. In passing, also make the difference std::ptrdiff_t which is signed (another requirement from the standard) and const-qualify pointer and reference. In principle, we could make reference now value_type and copy the dereferenced value. I leave this for a future change, if wanted.
It was the only one missing compared to RColumnDescriptorIterable. Also mark the operators as const.
Wrap the map iterator as done for RColumnRangeIterable. Also mark the operators as const.
Wrap the iterator as done for RColumnRangeIterable.
Fix the prefix operators to return references, add postfix operators.
pcanal
reviewed
Aug 22, 2025
pcanal
reviewed
Aug 22, 2025
pcanal
reviewed
Aug 22, 2025
pcanal
reviewed
Aug 22, 2025
pcanal
reviewed
Aug 22, 2025
pcanal
reviewed
Aug 22, 2025
Test Results 21 files 21 suites 3d 13h 7m 4s ⏱️ For more details on these failures, see this check. Results for commit 30d77be. |
jblomer
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFieldDescriptorIterable::operator->R{Cluster,ClusterGroup}DescriptorIterable,RExtraTypeInfoDescriptorIterableMore details in the individual commit messages.