Skip to content

Conversation

ferdymercury
Copy link
Collaborator

@ferdymercury ferdymercury commented Aug 27, 2025

Fixes #19076

This way they are executed one after the other, as they were in the original Makefile.

One hypothesis is that, even in "READ" mode, same ROOT file accessed concurrently might interfere. see eg #18954
due to TFile::SysClose or so.

Not sure if an alternative approach would be to read without global registration or so?

Fixes root-project#19076

This way they are executed one after the other, as they were originally in the original Makefile.
@ferdymercury ferdymercury requested a review from bellenot as a code owner August 27, 2025 10:07
@ferdymercury ferdymercury requested review from linev and pcanal August 27, 2025 10:08
@linev
Copy link
Member

linev commented Aug 27, 2025

It would be really strange if concurrent reading makes problems

@ferdymercury
Copy link
Collaborator Author

You mentioned that if failed 10% of the time on your Mac. Does the percentage change after adding this fix ?
Right now mac13, mac15 and mac15 went well.

It would be really strange if concurrent reading makes problems

Yeah, weird. Maybe the problem is the "delete" part after GetObject?

@linev
Copy link
Member

linev commented Aug 27, 2025

Last days I see no any failures for these tests.

And any GetObject problems cannot affect other process which only reads same file.

@ferdymercury
Copy link
Collaborator Author

ferdymercury commented Aug 27, 2025

Last days I see no any failures for these tests.

even after reenabling fixarr2 ?

I am exploring that in the CI, see #19762

@ferdymercury ferdymercury marked this pull request as draft August 27, 2025 14:04
Copy link

Test Results

    18 files      18 suites   2d 20h 38m 19s ⏱️
 3 635 tests  3 460 ✅  0 💤 175 ❌
64 024 runs  63 825 ✅ 23 💤 176 ❌

For more details on these failures, see this check.

Results for commit f2c571f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[roottest] test roottest-root-io-evolution-fixarr2 fails on some Mac
2 participants