Skip to content

Rename things for inclusive naming #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Rename things for inclusive naming #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/pull_request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def on_hold_label?(label)
label.downcase == ON_HOLD.downcase
end

def blacklisted?
def blocklisted?
User.where(github_name: username, blacklisted: true).exists?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, you should create a migration to rename the blacklisted attribute in the users table to get consistency

end
end
2 changes: 1 addition & 1 deletion app/services/slack_notification_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def initialize(params)
end

def send_notification
return if pr.blacklisted?
return if pr.blocklisted?

send(ACTION_METHODS[action]) if ACTION_METHODS.key? action
end
Expand Down