-
-
Notifications
You must be signed in to change notification settings - Fork 233
Block reload config files in Railtie if they already uploaded #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6a02452
to
b43c196
Compare
It affects tests which execute `rails runner`
d25a628
to
5db7fc4
Compare
@cjlarose, could you check tests? |
@vovanmozg are you still interested in moving forward with this PR? |
@Nuzair46 what do you think about this one? |
@pkuczynski @vovanmozg the failing tests seems to be an issue with Rails 6.1 not loading logger properly. `#{Rails.root.join("bin", "rails")} runner 'print "\#{Settings.default}|\#{Settings.custom}"'` After: `RUBYOPT="-r logger" #{Rails.root.join("bin", "rails")} runner 'print "\#{Settings.default}|\#{Settings.custom}"'` This makes ruby to load the logger before anything runs. |
@vovanmozg Are you able to contribute to this? Or I can help with implementing the rest. |
That would be awesome if you could take it over — I’m short on time right now. Really appreciate it! |
This PR will be superseded by #382 |
Fixes #352