Skip to content

Introduce logic for cvss_v4 severity #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

onshi
Copy link

@onshi onshi commented Mar 19, 2025

Hello Team,

I would like to introduce logic for properly rating severity for vulnerabilities which are estimated using only CVSS:4.0. This is a followup to rubysec/ruby-advisory-db#654

Currently vulnerabilities which are estimated using only CVSS:4.0 are using default fallback and are being marked as severity:unknown.

According to specification docs I think severity did not change between 3.0 and 4.0 standards

I did some refactoring based on code climate suggestions

Here is an example:

Using bundler-audit:0.9.2

Name: ruby-saml
Version: 1.17.0
CVE: CVE-2025-25293
GHSA: GHSA-92rq-c8cf-prrq
Criticality: Unknown
URL: https://github.com/SAML-Toolkits/ruby-saml/security/advisories/GHSA-92rq-c8cf-prrq
Title: Ruby SAML allows remote Denial of Service (DoS) with compressed SAML responses
Solution: update to '~> 1.12.4', '>= 1.18.0'

Using bundler-audit:0.10.0

Name: ruby-saml
Version: 1.17.0
CVE: CVE-2025-25293
GHSA: GHSA-92rq-c8cf-prrq
Criticality: High
URL: https://github.com/SAML-Toolkits/ruby-saml/security/advisories/GHSA-92rq-c8cf-prrq
Title: Ruby SAML allows remote Denial of Service (DoS) with compressed SAML responses
Solution: update to '~> 1.12.4', '>= 1.18.0'

Let me know if there is anything else I should adjust

@onshi onshi force-pushed the feature/cvss_v4_severity_logic branch 3 times, most recently from 9dad99e to 2464e66 Compare March 19, 2025 11:40
@onshi onshi force-pushed the feature/cvss_v4_severity_logic branch from 2464e66 to c7b9d1a Compare March 19, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant