Rename Location::file_with_nul to file_as_c_str
#145928
Open
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
T-libs-api
rustbot
added
S-waiting-on-review
|
@bors try jobs=x86_64-rust-for-linux |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Aug 27, 2025
Rename `Location::file_with_nul` to `file_as_c_str` try-job: x86_64-rust-for-linux
Darksonn
commented
Aug 27, 2025
src/ci/docker/scripts/rfl-build.sh
Outdated
| LINUX_VERSION=v6.16-rc1 | ||
| LINUX_VERSION=7a0a1152bc8dd86a6f12782595688fcc23e990cd |
There was a problem hiding this comment.
Oh, Rust didn't get the update to 6.17 yet. In that case, I don't think this will break the RfL job, so this isn't needed after all.
There was a problem hiding this comment.
Yes, I am waiting for another PR to get another temporary commit they need. I will do the update after these two land, since that will be the simplest for the PRs.
Darksonn
force-pushed
the
file_as_c_str
branch
from
2d36a83 to
dacae07
Compare
|
@bors try jobs=x86_64-rust-for-linux |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Aug 28, 2025
Rename `Location::file_with_nul` to `file_as_c_str` try-job: x86_64-rust-for-linux
5 tasks
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
26 tasks
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 28, 2025
…lett Rename `Location::file_with_nul` to `file_as_c_str` This renames the method to be consistent with the ongoing T-libs-api FCP found at rust-lang#141727 (comment). I did not rename the unstable feature as we are going to be stabilizing it soon anyway. This will probably break RfL, so it will require an updated commit hash for the Linux Kernel that I will add here soon. r? `@Amanieu`
bors
added a commit
that referenced
this pull request
Aug 28, 2025
Rollup of 9 pull requests Successful merges: - #142727 (wasm: rm static mut) - #143193 (Port `#[link]` to the new attribute parsing infrastructure ) - #144864 (No source fixes) - #145913 (Add spin_loop hint for LoongArch) - #145926 (compiletest: Remove several remnants of the old libtest-based executor) - #145928 (Rename `Location::file_with_nul` to `file_as_c_str`) - #145930 (`const`ify (the unstable) `str::as_str`) - #145941 (Disable `integer_to_ptr_transmutes` suggestion for unsized types) - #145953 (Update `icu_list` to 2.0) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the method to be consistent with the ongoing T-libs-api FCP found at #141727 (comment).
I did not rename the unstable feature as we are going to be stabilizing it soon anyway. This will probably break RfL, so it will require an updated commit hash for the Linux Kernel that I will add here soon.
r? @Amanieu