fix APITIT being treated as a normal generic parameter in suggestions #145929
+36
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
hkBst
reviewed
Aug 28, 2025
Comment on lines
+358
to
+359
| let ty_str = ty.to_string(); | ||
| if ty_str.contains("impl ") { |
There was a problem hiding this comment.
This seems like a fragile way to do detection.
There was a problem hiding this comment.
I agree, but (a) as far as I can tell, the Interner's ParamTy only has to implement ParamLike, which doesn't expose whether the generic parameter came from an impl Trait (specifically across crate boundaries); and (b) I, for one, can't come up with a way (other than impl Trait) to create a generic parameter whose name contains a space. If I've overlooked something, please let me know.
There was a problem hiding this comment.
Someone more knowledgeable than me will have to share the better way (if there is one).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #126395