Skip to content

Add more to the [workspace.dependencies] section in the top-level Cargo.toml #145947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 29, 2025
Merged

Add more to the [workspace.dependencies] section in the top-level Cargo.toml #145947

merged 15 commits into from
Aug 29, 2025

Conversation

nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Aug 27, 2025 •
edited
Loading

Following on from #145740.

r? @Kobzol

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-run-make Area: port run-make Makefiles to rmake.rs A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2025

The run-make-support library was changed

cc @jieyouxu

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in src/tools/opt-dist

cc @Kobzol

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Some changes occurred in exhaustiveness checking

cc @Nadrieril

aDotInTheVoid
aDotInTheVoid reviewed Aug 27, 2025
View reviewed changes
@Zalathar
Copy link
Contributor

I'm assuming that you mistakenly assigned me instead of:

r? Kobzol

@rustbot rustbot assigned Kobzol and unassigned Zalathar Aug 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2025

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@Kobzol
Copy link
Member

Kobzol commented Aug 28, 2025

I feel like this might regress over time, a tidy lint would be nice. But hopefully if people see at least one usage of workspace in Cargo.toml, they'll think of checking out the root Cargo.toml to see if there is perhaps that dependency already present.

Needs a rebase, otherwise you can r=me.

@bors
Copy link
Collaborator

bors commented Aug 28, 2025

☔ The latest upstream changes (presumably #145949) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment was marked as outdated.

Sign in to view
@nnethercote
Copy link
Contributor Author

I rebased.

@bors r=Kobzol

@bors
Copy link
Collaborator

bors commented Aug 28, 2025

📌 Commit 475c29d has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2025
bors added a commit that referenced this pull request Aug 28, 2025
@bors
Auto merge of #145947 - nnethercote:workspace-members-2, r=Kobzol
043cfe4 
Add more to the `[workspace.dependencies]` section in the top-level `Cargo.toml`

Following on from #145740.

r? `@Kobzol`
@bors
Copy link
Collaborator

bors commented Aug 28, 2025

⌛ Testing commit 475c29d with merge 043cfe4...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Aug 28, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 28, 2025
@nnethercote
Copy link
Contributor Author

"error: the evaluated program deadlocked" seems unrelated to this PR.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2025
@Zalathar Zalathar mentioned this pull request Aug 29, 2025
Merged
bors added a commit that referenced this pull request Aug 29, 2025
@bors
Auto merge of #145978 - Zalathar:rollup-0dzk72g, r=Zalathar
41f2b6b 
Rollup of 9 pull requests

Successful merges:

 - #143713 (Add a mailmap entry for gnzlbg)
 - #144275 (implement Sum and Product for Saturating(u*))
 - #144354 (fix(std): Fix undefined reference to __my_thread_exit on QNX 8.0)
 - #145387 (Remove TmpLayout in layout_of_enum)
 - #145793 (std library: use execinfo library also on NetBSD.)
 - #145884 (Test `instrument-mcount` codegen)
 - #145947 (Add more to the `[workspace.dependencies]` section in the top-level `Cargo.toml`)
 - #145972 (fix `core::marker::Destruct` doc)
 - #145977 (tests: Ignore basic-stepping.rs on riscv64)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2246dda into rust-lang:master Aug 29, 2025
10 of 11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 29, 2025
rust-timer added a commit that referenced this pull request Aug 29, 2025
@rust-timer
Unrolled build for #145947
b82094e 
Rollup merge of #145947 - nnethercote:workspace-members-2, r=Kobzol

Add more to the `[workspace.dependencies]` section in the top-level `Cargo.toml`

Following on from #145740.

r? `@Kobzol`
@jieyouxu
Copy link
Member

Already merged.
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 29, 2025
@nnethercote nnethercote deleted the workspace-members-2 branch August 29, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aDotInTheVoid aDotInTheVoid aDotInTheVoid left review comments

Assignees

@Kobzol Kobzol

Labels
A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-run-make Area: port run-make Makefiles to rmake.rs A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
8 participants
@nnethercote @rustbot @Zalathar @Kobzol @bors @rust-log-analyzer @jieyouxu @aDotInTheVoid