Skip to content

Feat: updated Argument<T> type for functional compatibility with other architectures #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

madhav-madhusoodanan
Copy link
Contributor

Summary

  1. Moved the type_and_name_from_c function of Argument<T> to the architecture-specific Argument<ArmArchitecture> struct, since this specific functionality exists only to serve how ARM intrinsics are defined.

Example:

  {
    "SIMD_ISA": "Neon",
    "name": "__crc32b",

    // The below values (of "arguments") would be passed into the `type_and_name_from_c` function
    "arguments": [
      "uint32_t a",
      "uint8_t b"
    ],
    "return_type": {
      "value": "uint32_t"
    },
  },

Context

This PR is part of the changes that were originally made in the x86 extension PR #1814 for intrinsic-test, and is intended to accomodate the changes made in PRs #1862 and #1863.

cc: @folkertdev @Amanieu

@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2025

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@madhav-madhusoodanan madhav-madhusoodanan force-pushed the intrinsic-test-argument-cleanup branch from 49d9802 to 1c699b6 Compare July 27, 2025 06:10
@folkertdev folkertdev added this pull request to the merge queue Jul 27, 2025
Merged via the queue into rust-lang:master with commit 6f71cdf Jul 27, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants